-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[![PR App][icn]][demo] | :-------------------:| ## 🧰 Changes Moves `mermaid` to an optional dependency. Adding `mermaid` appears to have increased the time to import the dist by a factor of almost 2. This is mostly a concern in our backend services, ie, `mdx-renderer` and `gitto`. This is also completely unnecessary since `mermaid` does not easily support SSR. (We'd have to get a working puppeteer setup to render it on the server, which is probably not worth the effort at the moment.) Also, I fixed up how `mermaid` class names were being applied in code tabs. ## 🧬 QA & Testing - [Broken on production][prod]. - [Working in this PR app][demo]. [demo]: https://markdown-pr-PR_NUMBER.herokuapp.com [prod]: https://SUBDOMAIN.readme.io [icn]: https://user-images.githubusercontent.com/886627/160426047-1bee9488-305a-4145-bb2b-09d8b757d38a.svg
- Loading branch information
1 parent
70ec34c
commit 7d5ee07
Showing
8 changed files
with
178 additions
and
47 deletions.
There are no files selected for viewing
Binary file added
BIN
+100 KB
...isual-regression-tests-rdmd-syntax-renders-mermaid-without-surprises-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.