Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta]: docs(cn): sharing-state-between-components #652

Merged
merged 14 commits into from
Mar 13, 2023

Conversation

qinhua
Copy link
Contributor

@qinhua qinhua commented Nov 8, 2021

No description provided.

Copy link

@dearalina dearalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qinhua 对于一些翻译进行了二次修改!请查看~

beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
@awxiaoxian2020
Copy link
Collaborator

It seems we still have conflicts.

@awxiaoxian2020
Copy link
Collaborator

@qinhua our ci failed.

please check it with yarn dev or other possible commands on your local machine to fix it.

@github-actions
Copy link

github-actions bot commented Feb 19, 2023

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 43.69 KB (🟡 +2 B) 132.88 KB
/500 43.67 KB (🟡 +2 B) 132.86 KB
/[[...markdownPath]] 43.86 KB (🟡 +2 B) 133.04 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@awxiaoxian2020
Copy link
Collaborator

awxiaoxian2020 commented Feb 19, 2023

It's weird that we need to modify the tsx file.

@qinhua
Copy link
Contributor Author

qinhua commented Feb 19, 2023

It's weird that we need modify the tsx file.

I found the title level has been modified after compare the MD file with main branch, and that will produce some errors in Navigation.tsx.

@daochouwangu 确认一下,现在翻译的时候,英文还要加行内代码符号吗?

Co-authored-by: TimLi <[email protected]>
@awxiaoxian2020 awxiaoxian2020 merged commit 8ac90c9 into reactjs:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Pending Modify 已校对,待修改阶段
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants