Lower the coffee-script-source version specifier #219
Conversation
There is an issue with the latest version of `coffee-script-source` outlined in jashkenas/coffeescript#382. The `react-rails` gemspec specifies a `~>1.9` version of `coffee-script-source`, which makes it impossible to back out of its most recent version in order to avoid the errors (for example, if you want to specify `~>1.8` in your app). This change lowers the dependency version in the `react-rails` gemspec so that a user can specify a lower working version.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
👍 |
|
Ohhh I see, this is more flexible than when I tried to lock to
(https://travis-ci.org/reactjs/react-rails/jobs/55249241) Nice, thanks! |
…-source-version-dependency Lower the coffee-script-source version specifier
|
Sure thing, thanks @rmosolgo! 👍 |
christopherstyles
deleted the
cs-lower-coffee-script-source-version-dependency
branch
Much apologies if this has already been addressed. I’ve seen a few similar issues (#167 (comment), #168), but no apparent resolution.
There seems to be a known issue with the latest version of
coffee-script-sourceoutlined in jashkenas/coffeescript#382.The
react-railsgemspec specifies a~>1.9version ofcoffee-script-source, which makes it impossible to back out of its most recent version, in order to avoid the errors (for example, if you want to specify~>1.8in your app).This change lowers the dependency version in the
react-railsgemspec so that a user can specify a lower working version.