Ensure componentMethodsHandler ignores private properties #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, react-docgen fails to parse a component that uses private properties such as
This fix allows react-docgen to parse this code.
Notes
t.ClassProperty.check
returns true even if the property is aClassPrivateProperty
. This explains the nature of the change, and why there seems to be a seemingly contradicting line:t.ClassProperty.check(path.node) && !t.ClassPrivateProperty.check(path.node)