feat: lazy initialize queryParamsToAdd (#1907)

Co-authored-by: Chris Pulman <[email protected]>
reactiveui · Nov 3, 2024 · e45c5f7 · e45c5f7
1 parent e13386f
commit e45c5f7
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/Refit/RequestBuilderImplementation.cs b/Refit/RequestBuilderImplementation.cs
@@ -646,7 +646,7 @@ bool paramsContainsCancellationToken
                     ret.Content = multiPartContent;
                 }
 
-                var queryParamsToAdd = new List<KeyValuePair<string, string?>>();
+                List<KeyValuePair<string, string?>>? queryParamsToAdd = null;
                 var headersToAdd = restMethod.Headers.Count > 0 ?
                     new Dictionary<string, string?>(restMethod.Headers)
                     : null;
@@ -737,6 +737,7 @@ bool paramsContainsCancellationToken
                         || queryAttribute != null
                     )
                     {
+                        queryParamsToAdd ??= [];
                         AddQueryParameters(restMethod, queryAttribute, param, queryParamsToAdd, i, parameterInfo);
                         continue;
                     }
@@ -756,9 +757,9 @@ bool paramsContainsCancellationToken
                 var urlTarget = BuildRelativePath(basePath, restMethod, paramList);
 
                 var uri = new UriBuilder(new Uri(BaseUri, urlTarget));
-                ParseExistingQueryString(uri, queryParamsToAdd);
+                ParseExistingQueryString(uri, ref queryParamsToAdd);
 
-                if (queryParamsToAdd.Count != 0)
+                if (queryParamsToAdd is not null && queryParamsToAdd.Count != 0)
                 {
                     uri.Query = CreateQueryString(queryParamsToAdd);;
                 }
@@ -1172,11 +1173,12 @@ var value in ParseEnumerableQueryParameterValue(
             }
         }
 
-        static void ParseExistingQueryString(UriBuilder uri, List<KeyValuePair<string, string?>> queryParamsToAdd)
+        static void ParseExistingQueryString(UriBuilder uri, ref List<KeyValuePair<string, string?>>? queryParamsToAdd)
         {
             if (string.IsNullOrEmpty(uri.Query))
                 return;
 
+            queryParamsToAdd ??= [];
             var query = HttpUtility.ParseQueryString(uri.Query);
             var index = 0;
             foreach (var key in query.AllKeys)