-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix black background on android #228
Fix black background on android #228
Conversation
LGTM |
I'm currently using this in my package.json for all those who need this fix
|
BUMP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as @samueljim tested it's ok
i test it too and the black background issue goes away
@Naturalclar can you merge these change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much!
Overview
Closes #226
Calling
setLayerType
fromsetRenderingMode
and passing null as the paint reference will cause the default paint to be used which will have it'sPorterDuffXfermode
set toSRC_OVER
. This causes the incorrect result.I've added a new
mRenderingMode
property that is used to callsetLayerType
fromdispatchDraw
where we have a paint reference with the correct PorterDuffXfermode set.Test Plan
I've updated the example app to use 0.75 and tested both platforms on both architectures.