Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mask flicker while navigating on Android #171

Conversation

gabrieldonadel
Copy link
Contributor

Overview

This PR fixes an issue many users have been experiencing on Android when navigating back from one screen to the other.

Closes #160

Test Plan

  1. On Android navigate to a screen with a component that users MaskedView
  2. Navigate back using the hardware button
  3. Observe the Mask no longer being removed before the screen is fully hidden

After

Screen.Recording.2022-09-19.at.09.59.25.mov

Before

Screen.Recording.2022-09-19.at.09.46.30.mov

@gabrieldonadel
Copy link
Contributor Author

@Naturalclar would you mind reviewing this PR?

@KikiTheMonk
Copy link

@Naturalclar yes please review this PR. lib is great and would love for this to be fixed :)

@ChristosFeizidis
Copy link

@Naturalclar please review it :)

@phantrungviet98
Copy link

phantrungviet98 commented Sep 29, 2022

@Naturalclar please review it. i am facing this issue also.

@gabrieldonadel
Copy link
Contributor Author

@FonDorn, GitHub shows that only those with write access to this repository can merge pull requests, could you please merge this one?

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Naturalclar Naturalclar merged commit 0a5a71f into react-native-masked-view:master Sep 30, 2022
@gabrieldonadel gabrieldonadel deleted the fix/flickers-when-navigating branch September 30, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flickers while navigating (Android)
6 participants