Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test coverage and automate publish #251

Merged
merged 37 commits into from
Apr 27, 2023
Merged

Conversation

ankitdas13
Copy link
Contributor

Note :- Please follow the below points while attaching test cases document link below:

- If label Tested is added then test cases document URL is mandatory.

- Link added should be a valid URL and accessible throughout the org.

- If the branch name contains hotfix / revert by default the BVT workflow check will pass.

Test Case Document URL
Please paste test case document link here....

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@b313033). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #251   +/-   ##
=========================================
  Coverage          ?   98.61%           
=========================================
  Files             ?       52           
  Lines             ?     1662           
  Branches          ?        0           
=========================================
  Hits              ?     1639           
  Misses            ?       23           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ankitdas13 ankitdas13 self-assigned this Apr 20, 2023
@ankitdas13 ankitdas13 added the TestingNotRequired TestingNotRequired label for BVT label Apr 20, 2023
@ankitdas13 ankitdas13 requested a review from ndhaka007 April 20, 2023 10:23
export VERSION=$(python3 setup.py --version)
python -m twine upload --verbose --repository testpypi dist/razorpay-$VERSION-py3-none-any.whl dist/razorpay-$VERSION.tar.gz
env:
TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is twine used for.
And we don't need gpg keys here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need twin for publish the sdk and we dont need gpg key here. Also for testing, I tried to publish our repo in test.pypi ( development repository ) and it dont ask any gpg key.

Check this job this once
https://github.com/razorpay/razorpay-python/actions/runs/4751988677/jobs/8441800971

@ankitdas13 ankitdas13 requested a review from ndhaka007 April 25, 2023 12:46
Copy link

@ndhaka007 ndhaka007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitdas13 ankitdas13 merged commit 60df5f0 into master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TestingNotRequired TestingNotRequired label for BVT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants