Reorder use super::* / super::internal::* #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightly started warning that many `use super::internal::*` imports under `par_iter` were unused -- see rust-lang/rust#38104. It turns out that all those modules also had `use super::*`, and `par_iter/mod.rs` has its own `use internal::*`, so apparently this now adds to what the other modules get. But we can't just remove those lines, because it doesn't work for older rustc. Instead we can reorder it so `super::internal::*` comes first, and nothing looks unused to the linter.
|
Ah, I was wondering what was up with those warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly started warning that many
use super::internal::*imports underpar_iterwere unused -- see rust-lang/rust#38104. It turns out thatall those modules also had
use super::*, andpar_iter/mod.rshas itsown
use internal::*, so apparently this now adds to what the othermodules get.
But we can't just remove those lines, because it doesn't work for older
rustc. Instead we can reorder it so
super::internal::*comes first,and nothing looks unused to the linter.