CMake cmake_minimum_required Deprecation Warning #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ...3.27 to the cmake_minimum_required * Add trailing new line to the file Signed-off-by: Ghorban M. Tavakoly <[email protected]>
* Raise minimum CMake version to 3.5, since compatibility with CMake < 3.5 will be removed from a future version of CMake. * Add ...3.27 to silent the CMake deprecation warning. Signed-off-by: Ghorban M. Tavakoly <[email protected]>
* Add ...3.27 to cmake_minimum_required * Remove extra trailing new line Signed-off-by: Ghorban M. Tavakoly <[email protected]>
Signed-off-by: Ghorban M. Tavakoly <[email protected]>
Signed-off-by: Ghorban M. Tavakoly <[email protected]>
Why not? |
Simply by applying it, I see the warning again! I have cmake 3.27.8. |
kilograham
previously approved these changes
Dec 15, 2023
kilograham
approved these changes
Dec 15, 2023
mungewell
pushed a commit
to mungewell/pico-sdk
that referenced
this pull request
Mar 18, 2024
* Add ...3.27 to the cmake_minimum_required, and make minimum 3.13 everywhere Signed-off-by: Ghorban M. Tavakoly <[email protected]> Co-authored-by: Graham Sanderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1545
Recently, when building pioasm and/or elf2uf2, CMake warns about cmake_minimum_required:
#1477 reported the issue, but submitted patch is not correct.