Added OpenAPI Codegen #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomleb
reviewed
Sep 27, 2024
tomleb
reviewed
Oct 1, 2024
|
@tomleb You were right, I worked to adjust both gengo and kube-openapi to compatible version and it worked! Thank you! |
tomleb
previously approved these changes
Oct 2, 2024
maxsokolovsky
approved these changes
Oct 3, 2024
tomleb
reviewed
Oct 3, 2024
| @@ -95,6 +95,7 @@ func (cg *ClientGenerator) typesGroupVersionDocPackage(name *types.Name, gv sche | |||
| p.HeaderComment = []byte(fmt.Sprintf(` | |||
| %s | |||
|
|
|||
| // +k8s:openapi-gen=true | |||
There was a problem hiding this comment.
We should make this dependent on the GenerateOpenAPI flag.
I thought we were okay with just doing the same as deepcopy but I misunderstood that deepcopy is generated when this generator runs..
It will also prevent having a huge amount of file changes in rancher/rancher when we update wrangler. (And also will prevent any change in behavior due to that new directive)
Could you make that change? Sorry about this.
ericpromislow
requested changes
Oct 9, 2024
tomleb
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue: 47007