fix: Improve composer.lock behavior with ignore-cache #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flagbrad
changed the title
flagbrad
changed the title
Also caused a test to fail because it wasn't expecting this output. I'm not sure how this test ever passed before, but this seems to be the correct thing to do.
|
@ramsey I think I fixed the problem that caused this test run to fail. I was seeing this locally, but assumed it was a problem with my version of expect or something. All tests are passing locally now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where composer.lock is not honored if ignore-cache is set to
true. Also, the recently added require-lock-file option had not been incorporated into tests and documentation, so added a test and docs (and fixed small typo in CONTRIBUTING)Motivation and context
Fixes #259. Discovered by our team when we decided to ignore cache and then noticed deployment's composer packages did not match our local dev packages.
How has this been tested?
Unfortunately, I know of no way to test action.yml without actually merging it and then trying it as a GitHub action.
Types of changes
PR checklist