Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version specification of coffeescript #1385

Closed
wants to merge 1 commit into from

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented Mar 27, 2018

Hello.

Is there any reason to stick CoffeeScript's version to 1.12.7? If nothing, it's better to remove the version specification.

Also coffee-loader already supports CoffeeScript 2.
ref: webpack-contrib/coffee-loader#30

@ytbryan
Copy link
Contributor

ytbryan commented Mar 27, 2018

cc @gauravtiwari

@gauravtiwari
Copy link
Member

@ohbarye Thanks, the idea behind coffeescript was that by default it will install 1.x to avoid any surprises and folks who want to use 2.x can install 2.x using yarn add coffeescript since it's a peer dependency.

2.x also requires setting up babel loader if I am not mistaken?

@ohbarye
Copy link
Contributor Author

ohbarye commented Mar 28, 2018

@gauravtiwari

2.x also requires setting up babel loader if I am not mistaken?

In my understanding, to be strict, it's not mandatory because the official site says below.

For older browsers or older versions of Node, however, transpilation is required.
http://coffeescript.org/#compatibility

Having said that, considering the current situation, many folks would need traspilation in most cases. So I believe the idea you clarified is fair enough!

Thanks for taking your time for this.

@ohbarye ohbarye closed this Mar 28, 2018
@ohbarye ohbarye deleted the relax-coffeescript-version branch March 28, 2018 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants