Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve asset paths order when deduping #75

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

brenogazzola
Copy link
Collaborator

Preserve the order of asset paths when deduplicating.

This closes #74, but it's only treating the symptoms, without actually fixing the cause (duplicate logical paths).

@miharekar I've tested this in your project, and it seems to work, but do you mind take another look to ensure I did not miss something?

@brenogazzola brenogazzola force-pushed the preserve-assets-order branch 3 times, most recently from 66fa66c to 693ba1e Compare February 21, 2022 20:06
@miharekar
Copy link

Yup, seems to do the trick! Thank you! 🙏

@brenogazzola brenogazzola requested a review from dhh February 21, 2022 21:14
@dhh dhh merged commit eb8b1e2 into main Feb 22, 2022
@brenogazzola brenogazzola deleted the preserve-assets-order branch February 22, 2022 11:39
@strobilomyces
Copy link

This also fixed an issue I was having with Stimulus controllers in development (I'm using esbuild-rails for globbing, but I also tried registering controllers singly). The entrypoint with the controllers would be correct in my builds folder, but for some reason the contents of that entrypoint were being replaced by stimulus.js when served. (And yes, I triple-checked that nothing was being served from public/assets.)

Prior to the error, I was using propshaft 0.6.1 and everything was running smoothly.

In staging/production, where my assets are precompiled, I never had any issues.

Anyway, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting paths messes up tailwind
4 participants