Fix typo in "Asset content" section of UPGRADING.md #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When referring to how to escape HTML tags, the documentation forgot to call the `content` method. When using `html_safe`, an exception will be raised because `html_safe` is not defined on `Propshaft::Asset`. Using `raw`, on the other hand, will call `to_s` on the `Propshaft::Asset` instance, returning an expected tag
|
Thanks! |
dhh
pushed a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When referring to how to escape HTML tags, the documentation forgot to call the
contentmethod.When using
html_safe, an exception will be raised becausehtml_safeis not defined onPropshaft::Asset.Using
raw, on the other hand, will callto_son thePropshaft::Assetinstance, returning an expected tag