Prevent damage to /* ... */ comments with missing source maps #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump on this. |
|
Another bump here. To be clear, Propshaft is corrupting data without this fix, albeit in a way that is relatively benign since it breaks the comment at the very end of the file. |
|
Thank you for the contribution @pond. Sorry it took me so long to check and merge this. |
|
Awesome. Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a source map is missing in a JS or CSS file that uses the
/* ... */style of comments, Propshaft would inadvertently substitute nothing viagsubfor the opening comment as well as the source map part, leaving a broken trailing*/.Fixed, with test coverage to prove it.