Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid loading ActionController::API constant #529

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Avoid loading ActionController::API constant #529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/jbuilder/railtie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@ module ApiRendering
end
end

ActiveSupport.on_load :action_controller do
if self == ActionController::API
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I could have also changed it to be self.name == "ActionController::API" to avoid breaking any Rails version
Or something like:

# not sure about the logic behind constant_loaded? method
constant_loaded?("ActionController::API") && (self == ActionController::API)

But I find relying on the :action_controller_api the most elegant and correct solution loading-wise

include ActionController::Helpers
include ActionController::ImplicitRender
end
ActiveSupport.on_load :action_controller_api do
include ActionController::Helpers
include ActionController::ImplicitRender
end
end
end
Expand Down