Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI against Rails 7.0 #526

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

okuramasafumi
Copy link
Contributor

No description provided.

@petergoldstein
Copy link
Contributor

Would it make sense to get a combined PR of this and #528 ? It seems odd that JBuilder is not running in CI against both Ruby 3.1 and Rails 7.0.x

cc: @berkos

@berkos
Copy link
Contributor

berkos commented Feb 3, 2022

Would it make sense to get a combined PR of this and #528 ? It seems odd that JBuilder is not running in CI against both Ruby 3.1 and Rails 7.0.x

cc: @berkos

@petergoldstein makes sense. I am happy to cherry-pick this commit in my PR if we decide so.

- ruby: 2.5
gemfile: rails_7_0
- ruby: 2.6
gemfile: rails_7_0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be testing on Ruby versions that are not supported by Rails 7. Rails 7 only supports 2.7+

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 I believe this is the exclusion list in the .yml so it won't run on those versions.

Given on the discussion here and that this PR has not been updated recently I've included Rails 7 and Ruby 3.1 in a single PR here that originally had only Ruby 3.1 testing support.

@rafaelfranca rafaelfranca merged commit a993a69 into rails:main Mar 8, 2022
@okuramasafumi okuramasafumi deleted the ci-against-rails-7 branch March 8, 2022 07:55
that-jill referenced this pull request in powerhome/power-web-development-interview May 1, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jbuilder](https://togithub.com/rails/jbuilder)
([changelog](https://togithub.com/rails/jbuilder/releases/tag/v2.12.0))
| `2.11.5` -> `2.12.0` |
[![age](https://developer.mend.io/api/mc/badges/age/rubygems/jbuilder/2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/jbuilder/2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/jbuilder/2.11.5/2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/jbuilder/2.11.5/2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>rails/jbuilder (jbuilder)</summary>

###
[`v2.12.0`](https://togithub.com/rails/jbuilder/releases/tag/v2.12.0)

[Compare
Source](https://togithub.com/rails/jbuilder/compare/v2.11.5...v2.12.0)

#### What's Changed

- Use OpenStruct only if available by
[@&#8203;yahonda](https://togithub.com/yahonda) in
[https://github.com/rails/jbuilder/pull/562](https://togithub.com/rails/jbuilder/pull/562)
- Replace deprecated `ProxyObject` with `BasicObject` by
[@&#8203;Earlopain](https://togithub.com/Earlopain) in
[https://github.com/rails/jbuilder/pull/563](https://togithub.com/rails/jbuilder/pull/563)
- Avoid loading `ActionController::API` constant by
[@&#8203;nvasilevski](https://togithub.com/nvasilevski) in
[https://github.com/rails/jbuilder/pull/529](https://togithub.com/rails/jbuilder/pull/529)
- Fixed a bug where
[#&#8203;501](https://togithub.com/rails/jbuilder/issues/501) broke
compatibility with Enumerable by
[@&#8203;yuki24](https://togithub.com/yuki24) in
[https://github.com/rails/jbuilder/pull/531](https://togithub.com/rails/jbuilder/pull/531)
- Fix namespace issue when generating jbuilder views by
[@&#8203;hahmed](https://togithub.com/hahmed) in
[https://github.com/rails/jbuilder/pull/536](https://togithub.com/rails/jbuilder/pull/536)
- Remove reliance on ERBTracker from rails by
[@&#8203;HParker](https://togithub.com/HParker) in
[https://github.com/rails/jbuilder/pull/504](https://togithub.com/rails/jbuilder/pull/504)
- Fix require path of dependency_tracker in railtie.rb by
[@&#8203;jalyna](https://togithub.com/jalyna) in
[https://github.com/rails/jbuilder/pull/552](https://togithub.com/rails/jbuilder/pull/552)

#### New Contributors

- [@&#8203;nvasilevski](https://togithub.com/nvasilevski) made their
first contribution in
[https://github.com/rails/jbuilder/pull/529](https://togithub.com/rails/jbuilder/pull/529)
- [@&#8203;okuramasafumi](https://togithub.com/okuramasafumi) made their
first contribution in
[https://github.com/rails/jbuilder/pull/526](https://togithub.com/rails/jbuilder/pull/526)
- [@&#8203;berkos](https://togithub.com/berkos) made their first
contribution in
[https://github.com/rails/jbuilder/pull/528](https://togithub.com/rails/jbuilder/pull/528)
- [@&#8203;hahmed](https://togithub.com/hahmed) made their first
contribution in
[https://github.com/rails/jbuilder/pull/536](https://togithub.com/rails/jbuilder/pull/536)
- [@&#8203;casperisfine](https://togithub.com/casperisfine) made their
first contribution in
[https://github.com/rails/jbuilder/pull/550](https://togithub.com/rails/jbuilder/pull/550)
- [@&#8203;jalyna](https://togithub.com/jalyna) made their first
contribution in
[https://github.com/rails/jbuilder/pull/552](https://togithub.com/rails/jbuilder/pull/552)
- [@&#8203;yahonda](https://togithub.com/yahonda) made their first
contribution in
[https://github.com/rails/jbuilder/pull/562](https://togithub.com/rails/jbuilder/pull/562)
- [@&#8203;Earlopain](https://togithub.com/Earlopain) made their first
contribution in
[https://github.com/rails/jbuilder/pull/563](https://togithub.com/rails/jbuilder/pull/563)
- [@&#8203;stefannibrasil](https://togithub.com/stefannibrasil) made
their first contribution in
[https://github.com/rails/jbuilder/pull/539](https://togithub.com/rails/jbuilder/pull/539)

**Full Changelog**:
rails/jbuilder@v2.11.5...v2.12.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/powerhome/power-web-development-interview).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants