This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Take error scenarios into account in aliveness test #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instance, if `message-ttl` is set to `0`, there will never be a message in the queue for the check. In this case, return `503` Fixes #855
|
@michaelklishin all set for review. |
michaelklishin
approved these changes
Oct 16, 2020
michaelklishin
added a commit
that referenced
this pull request
Oct 16, 2020
Take error scenarios into account in aliveness test (cherry picked from commit 6b62271)
|
Backported to |
michaelklishin
added a commit
that referenced
this pull request
Oct 19, 2020
* Remove documentation to the now deprecated One True Health Check™. It is too intrusive and too prone to false positives to recommend. * Aliveness test is also a health check, and will respond with a 200 or 503 as of #856
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #855