Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

train_continuous() coerces new to numeric #374

Merged
merged 6 commits into from
Nov 1, 2023

Conversation

teunbrand
Copy link
Contributor

This PR aims to fix #369 and fix tidyverse/ggplot2#2377.

I chose to coerce instead of the two alternatives in #369, because of this expectation:

#' Strips attributes and always returns a numeric vector

The reprex from the ggplot2 issue should now work:

devtools::load_all("~/packages/scales/")
#> ℹ Loading scales
library(ggplot2)

df <- data.frame(x = bit64::as.integer64(1:10))
ggplot(df) + geom_histogram(aes(x))
#> Don't know how to automatically pick scale for object of type <integer64>.
#> Defaulting to continuous.
#> `stat_bin()` using `bins = 30`. Pick better value with `binwidth`.

Created on 2022-12-06 by the reprex package (v2.0.1)

@thomasp85
Copy link
Member

And update this

@teunbrand
Copy link
Contributor Author

Done.

@thomasp85 thomasp85 merged commit 636b1ca into r-lib:main Nov 1, 2023
11 of 12 checks passed
@teunbrand teunbrand deleted the train_int64 branch November 1, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: train_continuous() with integer64 Add support for integer64 variable types
2 participants