send_query_stale_warning: assign result #373
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @krlmlr
Seeing ( intermittent ) failures in odbc pipelines, that I am having trouble replicating on my boxes. They are windows only + sql server specific, though I think that may be a red herring.
I think the failures may be caused by the return value of
dbSendQuery
in the test below not being assigned to a named variable. I wonder if because of that, it's possible for the "rvalue" result object to be garbage collected before thedbDisconnect
call below. If that were to happen, there would be no warning emitted when the disconnect call goes through, as the result has already been destroyed/released.I listed four failures pipeline above. In between failure three and four I ran an identical job using this branch of
DBItest
and the pipeline passed. Somewhat unscientific, I know, and without a windows box to test on this is mostly guesswork.Strike against this theory is that I can't think of any recent changes that would have caused this issue to suddenly flare up. Then again, I always struggle with issues related to garbage collection.
Cheers.