Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send_query_stale_warning: assign result #373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

detule
Copy link

@detule detule commented Sep 28, 2024

Hi @krlmlr

Seeing ( intermittent ) failures in odbc pipelines, that I am having trouble replicating on my boxes. They are windows only + sql server specific, though I think that may be a red herring.

I think the failures may be caused by the return value of dbSendQuery in the test below not being assigned to a named variable. I wonder if because of that, it's possible for the "rvalue" result object to be garbage collected before the dbDisconnect call below. If that were to happen, there would be no warning emitted when the disconnect call goes through, as the result has already been destroyed/released.

I listed four failures pipeline above. In between failure three and four I ran an identical job using this branch of DBItest and the pipeline passed. Somewhat unscientific, I know, and without a windows box to test on this is mostly guesswork.

Strike against this theory is that I can't think of any recent changes that would have caused this issue to suddenly flare up. Then again, I always struggle with issues related to garbage collection.

Cheers.

@krlmlr krlmlr force-pushed the test/stale_send_query branch from 24effd8 to c28fdf4 Compare October 1, 2024 06:26
@krlmlr
Copy link
Member

krlmlr commented Oct 1, 2024

Thanks, looks good, and I like the symmetry with the test above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants