Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Think about argument to dbRemoveTable() that drops only if the table exists #197

Closed
krlmlr opened this issue Oct 15, 2017 · 2 comments
Closed

Think about argument to dbRemoveTable() that drops only if the table exists #197

krlmlr opened this issue Oct 15, 2017 · 2 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Oct 15, 2017 •
edited
Loading

Useful for dbWriteTable() or for manually implementing it (#74).

Naming suggestion: dbRemoveTable(safe = TRUE)
@hadley
Copy link
Member

hadley commented Dec 4, 2017 •
edited
Loading

I think the right argument is force = TRUE following the convention of rm; the default would be force = FALSE

krlmlr added a commit to r-dbi/RSQLite that referenced this issue Apr 24, 2018
@krlmlr
implement dbRemoveTable(fail_if_missing = FALSE)
012bd8d 
- New argument `fail_if_missing` (default: `TRUE`) to `dbRemoveTable()` (r-dbi/DBI#197).
krlmlr added a commit to r-dbi/RPostgres that referenced this issue Apr 24, 2018
@krlmlr
implement dbRemoveTable(fail_if_missing = FALSE)
110ff93 
- New argument `fail_if_missing` (default: `TRUE`) to `dbRemoveTable()` (r-dbi/DBI#197).
krlmlr added a commit to r-dbi/RMariaDB that referenced this issue Apr 24, 2018
@krlmlr
implement dbRemoveTable(fail_if_missing = FALSE)
549aef2 
- New argument `fail_if_missing` (default: `TRUE`) to `dbRemoveTable()` (r-dbi/DBI#197).
@krlmlr
Copy link
Member Author

krlmlr commented Apr 24, 2018

I've decided in favor of fail_if_missing = TRUE, because --force in rm implies more than just "skip if missing".

@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @krlmlr