Drop findIndirect() algorithm #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to cppreference.com, std::invoke is supposed to deal with one level of indirection automatically (e.g. if the first parameter is a smart pointer), so we should not need findIndirect() for that. What findIndirect() effectively does is enabling the second level of indirection, and that kind of stuff better be spelled out in the code instead of being magically consumed by an algorithm.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This retracts the algorithm introduced in
#840#760 - it is unnecessary, asstd::ranges::find()can handle it just fine with the current toolchain versions.The algorithm didn't show up in any release so it's safe to remove it.The algorithm was introduced before 0.9 beta but I only found my mistake after this PR was merged. If someone ends up missing it, it can easily be reintroduced as an alias tostd::ranges::find.