Fix downloading encrypted files to a temporary location #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case had two problems: - The temporary file we decrypt into wasn't opened. - The temporary encrypted file was removed before renaming the decrypted one into its place. Removing a temporary file however resets its file name (for good reasons, that might meanwhile be owned by a different user), and thus renaming fails due to an empty destination. Instead we just swap the two temporary files now, as the final destination of the download is a temporary location we decide on here anyway which one we return ultimately doesn't matter.
KitsuneRal
approved these changes
Nov 21, 2024
|
CI failure seems unrelated to this change, should I merge anyway? |
|
yes, the CI fails when being run for branches that come from a fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case had two problems:
Instead we just swap the two temporary files now, as the final destination of the download is a temporary location we decide on here anyway which one we return ultimately doesn't matter.