Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality so that sendEvent can handle events with file content. #833

Closed
wants to merge 1 commit into from

Conversation

nvrWhere
Copy link
Collaborator

Title

@TobiasFella
Copy link
Member

Do I understand correctly that the intention here is for the client to create an event with the file's url pointing at a local file and the library then uploads that file and sends the event automatically?

@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Nov 18, 2024
@KitsuneRal
Copy link
Member

I have the same question as Tobias; also, it looks like Quotest is crashing now, something is certainly off.

@nvrWhere
Copy link
Collaborator Author

Yeah technically this is what postFile does behind the scenes. I'm looking at having NeoChat form most the events itself going forward as it makes it easier to handle all the complexities. However thinking about it this is not a good idea if I want to work this way I should do the upload myself and then create the event to post

@nvrWhere nvrWhere closed this Nov 19, 2024
@KitsuneRal
Copy link
Member

There's also an option to send an event with a pre-reserved media id and then upload a file to that id, if that's the UX style you prefer.

@nvrWhere
Copy link
Collaborator Author

Indeed, also looking at postFile are we happy that in the same vein it effectively creates an event with the local filepath and then replaces when the upload finishes?

@KitsuneRal
Copy link
Member

Well, that was exactly the intention :) so that the user could see the file they attached even before it's uploaded. I wouldn't mind seeing the whole process driven by the library, but we still want to visualise the uploading process and that requires callouts/callbacks separate from the event sending stuff. So I don't know how much you're getting from pre-packing the event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants