Use the error message provided by the server's media endpoints #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is usually more descriptive than what Qt gives us, like "remote media download failed" instead of an empty error message.
KitsuneRal
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Indeed. This is a side-effect of MxcReply not being able to use BaseJob requests that already deal with it (or the other way around, BaseJob not being written in such a way that could be used from NetworkAccessManager - thread-safety being one of the issues).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is usually more descriptive than what Qt gives us, like "remote media download failed" instead of an empty error message.
Before
After