Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving access token to keychain #827

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

TobiasFella
Copy link
Member

The timing here changed and without this patch, we're trying to save the access token before we even have it available

The timing here changed and without this patch, we're trying to save the access token before we even have it available
@TobiasFella TobiasFella marked this pull request as ready for review November 10, 2024 13:16
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that explains why I don't see recent logins being "saved" under an empty slot in the keychain. Thanks for tracking this down.

@KitsuneRal KitsuneRal added the regression Something broken since the last release label Nov 10, 2024
@KitsuneRal KitsuneRal merged commit 8f5b4ea into dev Nov 10, 2024
4 checks passed
@vkrause
Copy link
Member

vkrause commented Nov 10, 2024

Confirmed, fixes the problems in Itinerary with 0.9.0 as well. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Something broken since the last release
Projects
Status: 0.9 - Done
Development

Successfully merging this pull request may close these issues.

3 participants