Tweak Avatar::Private::get() #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic remains mostly the same, except that: 1) nullptr callbacks are simply ignored, not even reported in Debug mode 2) The newly requested size has to exceed that of the existing image on both dimensions, not any of them. This allows to freely request sizes like 32x65535 and then 65535x64 without invalidating the cache. 3) After receiving the image from the network it is stored as is, without immediate scaling to whatever size the request has been initiated with - it is scaled to the requested size before returning the image anyway. 4) Most of request errors except NetworkError and Timeout (think 400, 403, 404 etc.) invalidate the image source entirely now, avoiding repeated attempts to retrieve an image that is not retrievable. The rest is mostly better names (_largestRequestedSize instead of _requestedSize, Invalid instead of Banned, etc.), comments and code readability improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (further) improves network traffic for Quaternion 0.0.96, now that its image provider is
Avatar-aware.The logic remains mostly the same, except that:
NetworkErrorandTimeout(think 400, 403, 404 etc.) invalidate the image source entirely now, avoiding repeated attempts to retrieve an image that is not retrievable.The rest is mostly better names (
_largestRequestedSizeinstead of_requestedSize,Invalidinstead ofBanned, etc.), comments and code readability improvements.