Eventmanager #1714
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,18 @@ | ||||||||||||||||||||||
| package upgrades | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| import ( | ||||||||||||||||||||||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||||||||||||||||||||||
| "github.com/cosmos/cosmos-sdk/types/module" | ||||||||||||||||||||||
| upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types" | ||||||||||||||||||||||
| "github.com/quicksilver-zone/quicksilver/app/keepers" | ||||||||||||||||||||||
| ) | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| func V010900UpgradeHandler( | ||||||||||||||||||||||
| mm *module.Manager, | ||||||||||||||||||||||
| configurator module.Configurator, | ||||||||||||||||||||||
| appKeepers *keepers.AppKeepers, | ||||||||||||||||||||||
| ) upgradetypes.UpgradeHandler { | ||||||||||||||||||||||
| return func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) { | ||||||||||||||||||||||
| return mm.RunMigrations(ctx, configurator, fromVM) | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
Comment on lines
+15
to
+17
There was a problem hiding this comment. 🛠️ Refactor suggestion Add error handling for RunMigrations The migration might fail, and it would be helpful to wrap the error with context about which upgrade failed. - return mm.RunMigrations(ctx, configurator, fromVM)
+ newVM, err := mm.RunMigrations(ctx, configurator, fromVM)
+ if err != nil {
+ return nil, fmt.Errorf("failed to run v1.9.0 upgrade migrations: %w", err)
+ }
+ return newVM, nil📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
Comment on lines
+10
to
+18
There was a problem hiding this comment. Add EventManager migration logic The upgrade handler currently only runs default migrations without initializing or migrating the new EventManager state. Given that this upgrade introduces the EventManager feature (as per PR objectives), consider adding custom migration logic to:
Here's a suggested structure: func V010900UpgradeHandler(
mm *module.Manager,
configurator module.Configurator,
appKeepers *keepers.AppKeepers,
) upgradetypes.UpgradeHandler {
return func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
+ // Initialize EventManager state
+ if err := initializeEventManager(ctx, appKeepers); err != nil {
+ return nil, err
+ }
+
+ // Migrate existing async operations if needed
+ if err := migrateAsyncOperations(ctx, appKeepers); err != nil {
+ return nil, err
+ }
+
return mm.RunMigrations(ctx, configurator, fromVM)
}
}
|
||||||||||||||||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Store upgrade handling needs to be implemented for the eventmanager module
The verification reveals that while there's a v1.9.0 upgrade handler, it doesn't include the required store upgrades for the new eventmanager module. For breaking changes involving new store keys:
emtypes.StoreKeyAction items:
eventmanagerto store upgrades in the v1.9.0 upgrade handler🔗 Analysis chain
Verify upgrade handling for the new store key.
The store key addition is correctly placed. However, since adding a new store key is a breaking change:
Let's verify the upgrade handling:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 5486
Script:
Length of output: 5757
Script:
Length of output: 1764