Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable more linters, update golangci-lint to v1.31 #2775

Merged
merged 4 commits into from
Sep 14, 2020
Merged

enable more linters, update golangci-lint to v1.31 #2775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b944882
enable the asciicheck linter
marten-seemann Aug 6, 2020
f886be4
enable the gofmt linter
marten-seemann Aug 6, 2020
5d24d3b
enable the exportloopref linter
marten-seemann Sep 12, 2020
4414060
update golangci-lint to v1.31
marten-seemann Sep 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ jobs:
uses: golangci/golangci-lint-action@v1
with:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.30
version: v1.31
3 changes: 3 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,13 @@ linters-settings:
linters:
disable-all: true
enable:
- asciicheck
- deadcode
- depguard
- exportloopref
- goconst
- goimports
- gofmt
- gosimple
- ineffassign
- misspell
Expand Down
4 changes: 2 additions & 2 deletions integrationtests/self/self_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ var _ = BeforeSuite(func() {
panic(err)
}
tlsConfig = &tls.Config{
Certificates: []tls.Certificate{tls.Certificate{
Certificates: []tls.Certificate{{
Certificate: [][]byte{leafCert.Raw},
PrivateKey: leafPrivateKey,
}},
Expand Down Expand Up @@ -260,7 +260,7 @@ func generateTLSConfigWithLongCertChain(ca *x509.Certificate, caPrivateKey *rsa.
rawCerts[0] = leafCert.Raw

return &tls.Config{
Certificates: []tls.Certificate{tls.Certificate{
Certificates: []tls.Certificate{{
Certificate: rawCerts,
PrivateKey: leafPrivateKey,
}},
Expand Down