Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: fix regression in perf optimization of ReflectionValueResolver #44817

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Nov 28, 2024

Copy link

quarkus-bot bot commented Nov 28, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 06f4006.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand
Copy link
Contributor

geoand commented Nov 29, 2024

@mkouba I think the title of this is incorrect, no?

@mkouba
Copy link
Contributor Author

mkouba commented Nov 29, 2024

@mkouba I think the title of this is incorrect, no?

Well, it's a fix of a regression caused by a performance optimization of ReflectionValueResolver 🤷.

@geoand
Copy link
Contributor

geoand commented Nov 29, 2024 via email

@mkouba mkouba changed the title Qute: fix perf optimization in ReflectionValueResolver Qute: fix regression in perf optimization of ReflectionValueResolver Nov 29, 2024
@mkouba
Copy link
Contributor Author

mkouba commented Nov 29, 2024

Yeah I know, but someone at looking at the PR (through the release notes for example) would be misled into believing this is a performance fix, when it's in fact a bug fix

Ok, is it better now? ;-)

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkouba mkouba merged commit 0aff1b5 into quarkusio:main Nov 29, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 29, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.3 Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus Qute broken in 3.16
3 participants