Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring quarkus.bootstrap.effective-model-builder as a POM property #44487

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

aloubyansky
Copy link
Member

@aloubyansky aloubyansky commented Nov 13, 2024

Complete list of changes:

  • Support configuring quarkus.bootstrap.effective-model-builder as a POM property
  • suport resolving JAR artifacts with classifiers from the classes dir;
  • support the JAR and Surefire plugin configurations in the pluginManagement when initializing artifact source sets.

Fixes #9335

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Nov 13, 2024

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Nov 14, 2024

The CI failures look related.

@aloubyansky
Copy link
Member Author

I am not sure why that is, tbh

2024-11-13T23:52:57.0633866Z [ERROR] [ERROR] Some problems were encountered while processing the POMs:
2024-11-13T23:52:57.0638579Z [ERROR] Child module /home/runner/work/quarkus/quarkus/integration-tests/maven/target/test-classes/projects/multimodule-filtered-classifier/lib of /home/runner/work/quarkus/quarkus/integration-tests/maven/target/test-classes/projects/multimodule-filtered-classifier/pom.xml does not exist @ 

@aloubyansky aloubyansky force-pushed the effective-model-builder-pom-prop branch from f0bbe08 to 2153316 Compare November 15, 2024 07:48
@aloubyansky
Copy link
Member Author

Oh, i think i do. lib is filtered out in .gitignore

…POM property;

* suport resolving JAR artifacts with classifiers from the classes dir;
* support the JAR and Surefire plugin configurations in the pluginManagement when initializing artifact source sets.
@aloubyansky aloubyansky force-pushed the effective-model-builder-pom-prop branch from 2153316 to 405455a Compare November 15, 2024 08:01
Copy link

quarkus-bot bot commented Nov 15, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 405455a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess - History

  • Expecting actual not to be null - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual not to be null
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$FieldAccessEnhancedDelegate$1.assertValue(PublicFieldAccessInheritanceTest.java:141)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.doTestFieldAccess(PublicFieldAccessInheritanceTest.java:100)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess(PublicFieldAccessInheritanceTest.java:61)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)

📦 integration-tests/opentelemetry-vertx-exporter

io.quarkus.it.opentelemetry.vertx.exporter.grpc.SimpleGrpcNoTLSWithCompressionTest.test - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.opentelemetry.vertx.exporter.AbstractExporterTest Expecting Optional to contain a value but it was empty within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.it.opentelemetry.vertx.exporter.AbstractExporterTest 
Expecting Optional to contain a value but it was empty within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)

@gsmet gsmet merged commit 5593d6d into quarkusio:main Nov 15, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 15, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.0 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven kind/bugfix triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug using a maven classifier in dev mode
2 participants