-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Hibernate ORM 6.6.3.Final #44391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @gsmet (hibernate-orm) |
yrodiere
added
the
triage/needs-review
Issue that needs a review - remove label if all is clear
label
Nov 22, 2024
beikov
approved these changes
Nov 22, 2024
yrodiere
added
triage/waiting-for-ci
Ready to merge when CI successfully finishes
and removed
triage/needs-review
Issue that needs a review - remove label if all is clear
labels
Nov 22, 2024
Status for workflow
|
gsmet
approved these changes
Nov 23, 2024
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Ready to merge when CI successfully finishes
labels
Nov 23, 2024
gsmet
added
triage/waiting-for-ci
Ready to merge when CI successfully finishes
and removed
kind/bugfix
labels
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/hibernate-orm
Hibernate ORM
triage/flaky-test
triage/waiting-for-ci
Ready to merge when CI successfully finishes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #44378, #44386
Fixes #7462
Fixes #43056
Fixes #43296
Fixes #44454
Creating as draft since Hibernate ORM 6.6.3.Final hasn't been released yet.
We can't really upgrade to Hibernate ORM 6.6.2.Final, because the fix for HHH-16572 is causing problems, failing one test and more importantly probably breaking some user applications with unclear error messages -- possibly at runtime.
We decided to work on the following fixes/improvement in ORM, and upgrade to 6.6.3.Final directly, assuming they get merged in that release:
NOTE: HHH-16572 introduces a check for whether bytecode enhancement is supported for a given class. If that check is not reliable enough, we might want to change
io.quarkus.hibernate.orm.deployment.integration.QuarkusEnhancementContext#getUnsupportedEnhancementStrategy
to returnLEGACY
-- which would revert to the (dangerous, but backwards-compatible) behavior from Hibernate ORM 6.6.1.Final and earlier. I'm thinking about Quarkus 3.15 LTS in particular -- though we'll have to balance the danger of that earlier behavior against the danger of the check being unreliable.