Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account identifier clarity #2136

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Account identifier clarity #2136

merged 1 commit into from
Dec 19, 2024

Conversation

luke-quadratic
Copy link
Contributor

Prompted by a user who didn't understand what to put for account identifier.

Copy link

qa-wolf bot commented Dec 18, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Dec 18, 2024
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Dec 19, 2024 0:19am

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-2136 December 18, 2024 22:15 Inactive
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (399eb8b) to head (4330f50).
Report is 650 commits behind head on qa.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #2136      +/-   ##
==========================================
- Coverage   90.79%   88.91%   -1.88%     
==========================================
  Files         260      305      +45     
  Lines       57583    62021    +4438     
==========================================
+ Hits        52280    55149    +2869     
- Misses       5303     6872    +1569     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AyushAgrawal-A2 AyushAgrawal-A2 merged commit ceef298 into qa Dec 19, 2024
14 of 16 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the Account-identifier-clarity branch December 19, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants