Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data tables v1 #1915

Open
wants to merge 299 commits into
base: qa
Choose a base branch
from
Open

Data tables v1 #1915

wants to merge 299 commits into from

Conversation

ddimaria
Copy link
Collaborator

@ddimaria ddimaria commented Sep 24, 2024

Main branch for merging data table related work.

Closes #1412

Issues tracked here: https://app.quadratichq.com/file/5a2ee1de-6c95-4cc7-af6a-755b94746667

Copy link

qa-wolf bot commented Sep 24, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Sep 24, 2024
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ❌ Failed (Inspect) Nov 22, 2024 11:16pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1915 September 24, 2024 16:57 Inactive
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 80.31000% with 813 lines in your changes missing coverage. Please review.

Project coverage is 89.89%. Comparing base (e4746d1) to head (5004a80).
Report is 139 commits behind head on qa.

Files with missing lines Patch % Lines
...adratic-core/src/grid/file/serialize/data_table.rs 49.14% 208 Missing ⚠️
.../execution/execute_operation/execute_data_table.rs 88.67% 82 Missing ⚠️
...tic-core/src/controller/user_actions/data_table.rs 51.11% 66 Missing ⚠️
...ratic-core/src/controller/operations/data_table.rs 25.37% 50 Missing ⚠️
...dratic-core/src/controller/operations/operation.rs 0.00% 40 Missing ⚠️
quadratic-core/src/grid/data_table/mod.rs 88.91% 40 Missing ⚠️
quadratic-core/src/grid/sheet/rendering.rs 82.85% 36 Missing ⚠️
...uadratic-core/src/grid/data_table/table_formats.rs 52.30% 31 Missing ⚠️
...uadratic-core/src/controller/user_actions/cells.rs 8.33% 22 Missing ⚠️
...atic-core/src/controller/execution/run_code/mod.rs 83.17% 18 Missing ⚠️
... and 31 more
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #1915      +/-   ##
==========================================
- Coverage   90.96%   89.89%   -1.07%     
==========================================
  Files         250      271      +21     
  Lines       56531    59235    +2704     
==========================================
+ Hits        51422    53252    +1830     
- Misses       5109     5983     +874     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 September 25, 2024 22:48 Inactive
@ddimaria ddimaria changed the base branch from qa to manipulate-column-row September 25, 2024 22:50
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 September 27, 2024 15:42 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 September 27, 2024 16:22 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 September 27, 2024 16:43 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 September 27, 2024 22:53 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 September 28, 2024 14:31 Inactive
Base automatically changed from manipulate-column-row to qa September 30, 2024 17:34
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 October 1, 2024 12:31 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 October 1, 2024 18:24 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 October 2, 2024 20:16 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 October 3, 2024 01:03 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 October 3, 2024 01:52 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 October 3, 2024 01:55 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 November 18, 2024 23:51 Inactive
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 November 21, 2024 23:47 Inactive
@ddimaria ddimaria removed the prototype exploring an idea that can be played with label Nov 22, 2024
@ddimaria ddimaria temporarily deployed to quadratic-api-dev-pr-1915 November 22, 2024 23:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data tables
4 participants