Merge features: immediately update widgets for attributes with a provider default value #59960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Apply for widgets which show a key/description instead of the actual value
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
JuhoErvasti
changed the title
m-kuhn
reviewed
Dec 19, 2024
| @@ -267,6 +267,15 @@ void QgsMergeAttributesDialog::createTableWidgetContents() | |||
| currentComboBox->setCurrentIndex( currentComboBox->findData( QStringLiteral( "manual" ) ) ); | |||
| currentComboBox->blockSignals( false ); | |||
| } | |||
|
|
|||
| const QString widgetType = QgsGui::editorWidgetRegistry()->findBest( mVectorLayer, mFields.at( idx ).name() ).type(); | |||
There was a problem hiding this comment.
Should this be field.editorWidgetSetup().type() instead? Iirc findBest is using some heuristics while we can use a configuration here.
m-kuhn
reviewed
Dec 19, 2024
|
|
||
| const QString widgetType = QgsGui::editorWidgetRegistry()->findBest( mVectorLayer, mFields.at( idx ).name() ).type(); | ||
|
|
||
| const QStringList updateWidgetFor = QStringList() << QStringLiteral( "ValueMap" ) |
There was a problem hiding this comment.
What is the reason for this hardcoded list of widget types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply for widgets which show a key/description instead of the actual values. Addresses part of #59494 (the additional context part, the main part AFAIK is the intended behavior and is meant to be addressed with a "merge policy" feature)
Backport to 3.40 requested.
before:
after:
