Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade to Fedora 41 #59595

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

ci: upgrade to Fedora 41 #59595

wants to merge 3 commits into from

Conversation

t0b3
Copy link
Contributor

@t0b3 t0b3 commented Nov 26, 2024

ci: upgrade to Fedora 41

@github-actions github-actions bot added this to the 3.42.0 milestone Nov 26, 2024
@t0b3 t0b3 marked this pull request as draft November 26, 2024 06:37
Copy link

github-actions bot commented Nov 26, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit ca94f8a)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit ca94f8a)

Copy link

github-actions bot commented Nov 26, 2024

Tests failed for Qt 6

One or more tests failed using the build from commit c9a95c0

composerlabel_renderhtml (renderAsHtml)

composerlabel_renderhtml

Test failed at renderAsHtml at tests/src/core/testqgslayoutlabel.cpp:312

Rendered image did not match tests/testdata/control_images/composer_label/expected_composerlabel_renderhtml/expected_composerlabel_renderhtml.png (found 6342 pixels different)

composerlabel_renderhtmllineheight (renderAsHtmlLineHeight)

composerlabel_renderhtmllineheight

Test failed at renderAsHtmlLineHeight at tests/src/core/testqgslayoutlabel.cpp:340

Rendered image did not match tests/testdata/control_images/composer_label/expected_composerlabel_renderhtmllineheight/expected_composerlabel_renderhtmllineheight.png (found 28075 pixels different)

picture_svg_fixed_size

picture_svg_fixed_size

Test failed at testRenderSvgFixedSize at tests/src/python/test_qgsannotationpictureitem.py:1069

Rendered image did not match tests/testdata/control_images/annotation_layer/expected_picture_svg_fixed_size/expected_picture_svg_fixed_size.png (found 1652 pixels different)

picture_svg_locked_aspect

picture_svg_locked_aspect

Test failed at testRenderSvgLockedAspect at tests/src/python/test_qgsannotationpictureitem.py:844

Rendered image did not match tests/testdata/control_images/annotation_layer/expected_picture_svg_locked_aspect/expected_picture_svg_locked_aspect.png (found 775 pixels different)

picture_svg_unlocked_aspect

picture_svg_unlocked_aspect

Test failed at testRenderSvgUnlockedAspect at tests/src/python/test_qgsannotationpictureitem.py:878

Rendered image did not match tests/testdata/control_images/annotation_layer/expected_picture_svg_unlocked_aspect/expected_picture_svg_unlocked_aspect.png (found 3748 pixels different)

Remote SVG

Remote SVG

Test failed at testRemoteSVG at tests/src/python/test_qgssvgcache.py:105

Rendered image did not match tests/testdata/control_images/svg_cache/expected_remote_svg/expected_remote_svg.png (found 2045 pixels different)

Remote SVG

Remote SVG

Test failed at testRemoteSVGBlocking at tests/src/python/test_qgssvgcache.py:278

Rendered image did not match tests/testdata/control_images/svg_cache/expected_remote_svg/expected_remote_svg.png (found 2045 pixels different)

Remote SVG as Text

Remote SVG as Text

Test failed at testRemoteSvgAsText at tests/src/python/test_qgssvgcache.py:154

Failed because rendered image and expected image are different dimensions (100x89 v2 100x110)

Remote SVG bad MIME type

Remote SVG bad MIME type

Test failed at testRemoteSvgBadMime at tests/src/python/test_qgssvgcache.py:201

Failed because rendered image and expected image are different dimensions (100x89 v2 100x100)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

@nyalldawson
Copy link
Collaborator

nyalldawson commented Nov 26, 2024

@t0b3
I've previously looked into this. There's regressions in qt library itself relating to svg rendering, and completely broken 3d views on newer qt6 releases (see #57640)

Until these upstream issues are fixed in qt we're stuck with the older release...

@nyalldawson
Copy link
Collaborator

@t0b3

#59619 fixes two of the failing tests, #59620 fixes another two

@troopa81 Can you take a look at the failing project style settings test here? That's relating to the CMYK work.

@t0b3
Copy link
Contributor Author

t0b3 commented Dec 3, 2024

@nyalldawson good progress 😃 5 tests have been fixed
it's only 8 tests with errors left https://cdash.orfeo-toolbox.org/viewTest.php?onlyfailed&buildid=27484

@troopa81
Copy link
Contributor

troopa81 commented Dec 4, 2024

@troopa81 Can you take a look at the failing project style settings test here? That's relating to the CMYK work.

Yes, I'll take a look

@troopa81 troopa81 mentioned this pull request Dec 4, 2024
@t0b3 t0b3 force-pushed the fc41 branch 2 times, most recently from 360dd0d to 911d47e Compare December 9, 2024 18:18
@t0b3
Copy link
Contributor Author

t0b3 commented Dec 9, 2024

@troopa81 there is still some CMYK assert failing
see https://cdash.orfeo-toolbox.org/test/15990846

@troopa81
Copy link
Contributor

Since #59834 , We got the current failure comment

/Deprecated/ supports message argument only for ABI v13.9 and later, or v12.16 or later

I opened an issue in PyQt-builder Python-PyQt/PyQt-builder#25

I could maybe check the abi version in cmake but it requires even more cmake code, and is I think overkill without the issue. I'd rather wait (for now) for it to be fixed upstream.

t0b3 added 3 commits December 20, 2024 08:00
clang v18 warns about ...
src/core/painting/qgsmaskpaintdevice.h:36:5: note: 'QgsMaskPaintEngine' has been explicitly marked deprecated here
Q_DECL_DEPRECATED QgsMaskPaintEngine( bool usePathStroker = false );
... while still being used in
src/core/painting/qgsmaskpaintdevice.cpp:65:23: note: in instantiation of function template specialization 'std::make_unique<QgsMaskPaintEngine, bool &>' requested here
mPaintEngine = std::make_unique<QgsMaskPaintEngine>( usePathStroker );
@t0b3
Copy link
Contributor Author

t0b3 commented Dec 20, 2024

temporary measure:

@nyalldawson
Copy link
Collaborator

@t0b3 maybe you could pin sip at the older version in dnf?

@troopa81
Copy link
Contributor

@t0b3 maybe you could pin sip at the older version in dnf?

The issue has been fixed upstream Python-PyQt/PyQt-builder#25

But I'm gonna add the abi minimum version in our SIP project so it doesn't fail.

@t0b3
Copy link
Contributor Author

t0b3 commented Dec 20, 2024

@t0b3 maybe you could pin sip at the older version in dnf?

The issue has been fixed upstream Python-PyQt/PyQt-builder#25

But I'm gonna add the abi minimum version in our SIP project so it doesn't fail.

perfect, so I return to the previous state 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants