-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: upgrade to Fedora 41 #59595
base: master
Are you sure you want to change the base?
ci: upgrade to Fedora 41 #59595
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Tests failed for Qt 6One or more tests failed using the build from commit c9a95c0 composerlabel_renderhtml (renderAsHtml)composerlabel_renderhtmlTest failed at renderAsHtml at tests/src/core/testqgslayoutlabel.cpp:312 Rendered image did not match tests/testdata/control_images/composer_label/expected_composerlabel_renderhtml/expected_composerlabel_renderhtml.png (found 6342 pixels different) composerlabel_renderhtmllineheight (renderAsHtmlLineHeight)composerlabel_renderhtmllineheightTest failed at renderAsHtmlLineHeight at tests/src/core/testqgslayoutlabel.cpp:340 Rendered image did not match tests/testdata/control_images/composer_label/expected_composerlabel_renderhtmllineheight/expected_composerlabel_renderhtmllineheight.png (found 28075 pixels different) picture_svg_fixed_sizepicture_svg_fixed_sizeTest failed at testRenderSvgFixedSize at tests/src/python/test_qgsannotationpictureitem.py:1069 Rendered image did not match tests/testdata/control_images/annotation_layer/expected_picture_svg_fixed_size/expected_picture_svg_fixed_size.png (found 1652 pixels different) picture_svg_locked_aspectpicture_svg_locked_aspectTest failed at testRenderSvgLockedAspect at tests/src/python/test_qgsannotationpictureitem.py:844 Rendered image did not match tests/testdata/control_images/annotation_layer/expected_picture_svg_locked_aspect/expected_picture_svg_locked_aspect.png (found 775 pixels different) picture_svg_unlocked_aspectpicture_svg_unlocked_aspectTest failed at testRenderSvgUnlockedAspect at tests/src/python/test_qgsannotationpictureitem.py:878 Rendered image did not match tests/testdata/control_images/annotation_layer/expected_picture_svg_unlocked_aspect/expected_picture_svg_unlocked_aspect.png (found 3748 pixels different) Remote SVGRemote SVGTest failed at testRemoteSVG at tests/src/python/test_qgssvgcache.py:105 Rendered image did not match tests/testdata/control_images/svg_cache/expected_remote_svg/expected_remote_svg.png (found 2045 pixels different) Remote SVGRemote SVGTest failed at testRemoteSVGBlocking at tests/src/python/test_qgssvgcache.py:278 Rendered image did not match tests/testdata/control_images/svg_cache/expected_remote_svg/expected_remote_svg.png (found 2045 pixels different) Remote SVG as TextRemote SVG as TextTest failed at testRemoteSvgAsText at tests/src/python/test_qgssvgcache.py:154 Failed because rendered image and expected image are different dimensions (100x89 v2 100x110) Remote SVG bad MIME typeRemote SVG bad MIME typeTest failed at testRemoteSvgBadMime at tests/src/python/test_qgssvgcache.py:201 Failed because rendered image and expected image are different dimensions (100x89 v2 100x100) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
@nyalldawson good progress 😃 5 tests have been fixed |
Yes, I'll take a look |
360dd0d
to
911d47e
Compare
@troopa81 there is still some CMYK assert failing |
cc0a71d
to
9cece4f
Compare
Since #59834 , We got the current failure comment
I opened an issue in PyQt-builder Python-PyQt/PyQt-builder#25 I could maybe check the abi version in cmake but it requires even more cmake code, and is I think overkill without the issue. I'd rather wait (for now) for it to be fixed upstream. |
clang v18 warns about ... src/core/painting/qgsmaskpaintdevice.h:36:5: note: 'QgsMaskPaintEngine' has been explicitly marked deprecated here Q_DECL_DEPRECATED QgsMaskPaintEngine( bool usePathStroker = false ); ... while still being used in src/core/painting/qgsmaskpaintdevice.cpp:65:23: note: in instantiation of function template specialization 'std::make_unique<QgsMaskPaintEngine, bool &>' requested here mPaintEngine = std::make_unique<QgsMaskPaintEngine>( usePathStroker );
temporary measure:
|
@t0b3 maybe you could pin sip at the older version in dnf? |
The issue has been fixed upstream Python-PyQt/PyQt-builder#25 But I'm gonna add the abi minimum version in our SIP project so it doesn't fail. |
perfect, so I return to the previous state 👍 |
ci: upgrade to Fedora 41