Feature: network use native system stores #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
==========================================
- Coverage 71.36% 71.11% -0.26%
==========================================
Files 45 45
Lines 2630 2645 +15
Branches 565 569 +4
==========================================
+ Hits 1877 1881 +4
- Misses 574 583 +9
- Partials 179 181 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Guts
force-pushed
the
feature/network-use-native-system-stores
branch
from
bef8bfa to
13920b6
Compare
Ducarouge
reviewed
Mar 1, 2024
Ducarouge
approved these changes
Mar 1, 2024
Guts
force-pushed
the
feature/network-use-native-system-stores
branch
from
0c55846 to
bfdbdb8
Compare
|
Guts
added a commit
that referenced
this pull request
Sep 4, 2024
…ough injection (#549) This PR follows up: - #544 - #444 It improve how system's store certificates are used, preferring a custom HTTP adapter to the SSL injection. It's mainly inspired from https://stackoverflow.com/a/78265028/2556577.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, a bundle of SSL certificates is used, through certifi. This PR allows QDT to use the system certificates store.
In this PR:
QDT_SSL_USE_SYSTEM_STORESenvironment variable to enable this feature as an opt-inRelated documentation: https://guts.github.io/qgis-deployment-cli/guides/howto_behind_proxy.html#id1
cc @DeCiZoR and @Niarolf