Generalize dataset builders as families #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/752
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6df4e79 with merge base 26223e9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kartikayk
reviewed
Apr 15, 2024
|
|
||
| Returns: | ||
| PreferenceDataset: The preference dataset built from StackExchange paired data. | ||
| PreferenceDataset: The preference datßaset built from source paired data. |
There was a problem hiding this comment.
Suggested change
| PreferenceDataset: The preference datßaset built from source paired data. | |
| PreferenceDataset: The preference dataset built from source paired data. |
There was a problem hiding this comment.
I cannot for the life of me tell you how that happened
kartikayk
approved these changes
Apr 15, 2024
ebsmothers
reviewed
Apr 15, 2024
| @@ -149,7 +149,7 @@ def format( | |||
|
|
|||
| class StackExchangedPairedTemplate(InstructTemplate): | |||
| """ | |||
| Prompt template for the StackExchangedPaired dataset. | |||
| Prompt template for preference datasets similar to StackExchanged paired. | |||
There was a problem hiding this comment.
This doesn't look right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
By moving
sourceto a parameter in the builder, we can genrealize dataset builders as "families" (i.e., alpaca family datasets, etc). Also update docstrings.Test plan
CI