-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images in Messages #1504
Merged
Merged
Images in Messages #1504
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
f63c096
[Pseudo-RFC] Images in Messages
joecummings da977ef
Updates
joecummings aab101c
<Replace this line with a title. Use 1 line only, 67 chars or less>
joecummings b0a6702
Updates
joecummings 12c3c30
Stub
joecummings 6458d1f
I AM A GOD
joecummings 3fb44c1
Add the doggo
joecummings dd111ba
What have I done....
joecummings f87eab7
Merge remote-tracking branch 'upstream/main' into image-in-messages
joecummings d833db1
LINT
joecummings c2e00ca
Fix Llava Instruct
joecummings 2bdb254
Last Llava test fixes
joecummings 2f8657d
Fix the Cauldron
joecummings 751186a
Move load_image to a utils loc
joecummings 7c63d16
Remove unnecessary changes
joecummings 08c8112
Cleanup
joecummings c9416d6
Actually use PIL images in test for formatting
joecummings 2f17dfe
Stop
joecummings eb97847
Convert images_dir to Path on the backend
joecummings 26ef618
Update docstring for format_content_with_images
joecummings 7cf3f33
Update API ref with new functions
joecummings 932b3d2
Update DummyTokenizer to account for images
joecummings 8007afd
Better docs rendering for data utils
joecummings 5a74b30
More formatting + updating Message test
joecummings c90b766
Whoops
joecummings 6fe061b
Update torchtune/data/_utils.py
joecummings File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally tubular
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Requests changes"
😭