Cast DictConfig -> dict in instantiate #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1450
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 87bf24d with merge base 4fba6cd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1450 +/- ##
==========================================
- Coverage 70.01% 69.79% -0.23%
==========================================
Files 268 271 +3
Lines 12937 13052 +115
==========================================
+ Hits 9058 9109 +51
- Misses 3879 3943 +64 ☔ View full report in Codecov by Sentry. |
11 tasks
RdoubleA
approved these changes
Aug 29, 2024
| @@ -103,4 +103,4 @@ def instantiate( | |||
| # Resolve all interpolations, or references to other fields within the same config | |||
| OmegaConf.resolve(config) | |||
|
|
|||
| return _instantiate_node(config, *args) | |||
| return _instantiate_node(OmegaConf.to_object(config), *args) | |||
There was a problem hiding this comment.
we should update the typing of _instantiate_node since now you're passing in a dict instead of DictConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1444
Tested via
Logged
type(lora_modules)here.On main:
<class 'omegaconf.listconfig.ListConfig'>On this PR:
<class 'list'>