Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix copying metadata during lowering #3320

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: Fix copying metadata during lowering #3320

merged 2 commits into from
Dec 12, 2024

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Dec 12, 2024

Description

Fixes #3221

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Dec 12, 2024
@github-actions github-actions bot requested a review from gs-olive December 12, 2024 01:08
@peri044 peri044 requested review from narendasan and removed request for gs-olive December 12, 2024 01:10
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would an alternative be to rerun the fake mode after lowering?

@peri044
Copy link
Collaborator Author

peri044 commented Dec 12, 2024

Would an alternative be to rerun the fake mode after lowering?

Yes, that would be an alternative. However, that requires us to maintain user provided inputs and dynamic shape range during tracing (provided at torch.export.export()). These inputs should be used via ShapeTensorProp or FakeTensorProp. Also, using this can modify the metadata for other ops in the graph which can get complicated.

@peri044 peri044 merged commit 184f601 into main Dec 12, 2024
45 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] view_to_reshape metadata mismatch
3 participants