Added [prop-decorator] code for unsupported property decorators (#14461) #16571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
| @@ -1241,6 +1241,10 @@ class A: | |||
| @property # OK | |||
| @dec | |||
| def g(self) -> int: pass | |||
| @dec # type: ignore[misc] | |||
| def h(self) -> int: pass | |||
| @dec # type: ignore[prop-decorator] | |||
There was a problem hiding this comment.
Unused ignores aren't caught here. You're missing @property.
….com/analog-cbarber/mypy into 14461-unsupported-property-decorator
This comment has been minimized.
This comment has been minimized.
pirate
approved these changes
May 17, 2024
JelleZijlstra
approved these changes
May 18, 2024
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/series.py:798: error: Unused "type: ignore" comment, use narrower [prop-decorator] instead of [misc] code [unused-ignore]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a decorator before a @Property now results in the narrower
prop-decoratorcode, which is a subcode ofmiscfor backward compatibility.I would have preferred to add a more general Unsupported error code and have this be a subcode of that, but this has to be a subcode of misc for backward compatibility.
Fixes #14461