Fix generic TypedDict/NamedTuple fixup #14675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
ilinum
pushed a commit
to ilinum/mypy
that referenced
this pull request
Feb 14, 2023
Fixes python#14638 TBH I don't remember why do we need to create the "incomplete" type alias (with empty type variables), and set up type variables later. But I didn't want to risk a larger refactoring and just fixed the missing calls surfaced by the issue instead.
ilinum
added a commit
that referenced
this pull request
Feb 15, 2023
Backport of #14675. --------- Co-authored-by: Ivan Levkivskyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14638
TBH I don't remember why do we need to create the "incomplete" type alias (with empty type variables), and set up type variables later. But I didn't want to risk a larger refactoring and just fixed the missing calls surfaced by the issue instead.