-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor semantic analyzer #4083
Comments
Should we close #3459 in favor of this? Or close this in favor of that? |
Also
|
I think this issue could use an update since there has been a lot of progress on this :) I believe we still want to not pass the second pass' instance to the first pass, but are there other concrete steps left in this issue? |
Here's what has been done:
The main missing thing is getting rid of direct references between passes. |
Closed in favor of #6204, which has a wider scope. |
The current semantic analyzer is hard to understand and modify. Here some ideas for how to improve things:
mypy.analyzer[123]
).SemanticAnalyzer
instance to the first and third passes. Instead, move any shared functionality to a utility class (or functions), and put them in a separate module such asmypy.analyzeutil
.SemanticAnalyzerPass[123]
.The text was updated successfully, but these errors were encountered: