Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94215: Reproducer for segfault in frame_setlineno() #94563

Merged
merged 1 commit into from
Jul 7, 2022
Merged

gh-94215: Reproducer for segfault in frame_setlineno() #94563

merged 1 commit into from
Jul 7, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 5, 2022 •
edited by bedevere-bot
Loading

@tiran
Copy link
Member Author

tiran commented Jul 5, 2022

I can't promise that the change is correct. The test reproducer no longer crashes with a segfault and refleak tests do not report any reference leaks either.

@tiran tiran added type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jul 5, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 26da1e6b466408253845ac3e30933012646b6ee2 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 5, 2022
@tiran
Copy link
Member Author

tiran commented Jul 5, 2022

My fix is incorrect. It introduces a reference leak.

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Jul 5, 2022 •
edited
Loading

My fix is incorrect. It introduces a reference leak.

Where is the refleak ? Can you provide a link to failing buildbot? @tiran

@tiran
Copy link
Member Author

tiran commented Jul 5, 2022

As I said my attempt to solve the segfault introduces a refleak. You can easily reproduce the refleak by running test_pdb with test runner option -R.

@tiran tiran force-pushed the gh-94215-lineno-crash branch from 8887f4b to 05a9f9a Compare July 7, 2022 10:04
@tiran tiran changed the title gh-94215: Reproducer and fix for segfault in frame_setlineno() gh-94215: Reproducer for segfault in frame_setlineno() Jul 7, 2022
@tiran tiran marked this pull request as ready for review July 7, 2022 10:08
@tiran tiran added the tests Tests in the Lib/test dir label Jul 7, 2022
@tiran
Copy link
Member Author

tiran commented Jul 7, 2022

I have removed the invalid fix and cleaned up the test. I'm going to add and backport the new tests so we have a reproducer for possible ref leak and crashes available.

@tiran tiran added the skip news label Jul 7, 2022
@tiran tiran merged commit de58842 into python:main Jul 7, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2022
@tiran @miss-islington
pythongh-94215: Add reproducer for segfault in frame_setlineno() (pyt…
27e0401 
…honGH-94563)

(cherry picked from commit de58842)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 7, 2022
@bedevere-bot
Copy link

GH-94652 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Jul 7, 2022
@miss-islington @tiran
gh-94215: Add reproducer for segfault in frame_setlineno() (GH-94563)
421c4b0 
(cherry picked from commit de58842)

Co-authored-by: Christian Heimes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

@markshannon markshannon Awaiting requested review from markshannon

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @bedevere-bot @kumaraditya303 @miss-islington