bpo-45708: Support underscore separators when formatting Decimal objects #29438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
Nov 6, 2021
serhiy-storchaka
approved these changes
Nov 6, 2021
|
This will break tests for vendors that de-bundle mpdecimal and use the upstream version. Fedora/CentOS/RHEL are not affected but Debian/Ubuntu use standaline libmpdecimal. |
Darn. Thanks, @tiran - my instincts were telling me that we shouldn't modify libmpdec directly, but I failed to figure out why it was a problem. Closing here; let's continue discussion on the issue. |
|
Re-opening as a proof-of-concept draft PR to show one possible way that we could take this forward without touching libmpdec. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Closing. This has served its purpose as a POC. I'm not likely to have time to turn it into a production-quality PR any time soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends formatting for
Decimalobjects to support underscores as thousands separators (as described in PEP 515). Previously,Decimalonly supported commas as thousands separators, while int and float support both commas and underscores.https://bugs.python.org/issue45708