gh-123085: _compile_importlib: Avoid copying sources before compilation #124131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This now doesn't copy resources of |
|
!buildbot fedora |
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit cade8d2 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
vstinner
reviewed
Sep 17, 2024
|
!buildbot fedora |
|
🤖 New build scheduled with the buildbot fleet by @jaraco for commit 8cd8fe9 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
I pushed a new commit to trim down the logic substantially. Let me know what you think. |
jaraco
approved these changes
Sep 17, 2024
|
Looks good, thank you! |
|
I cherry-picked the change to python/importlib_resources@cc5d9cbb6e. |
savannahostrowski
pushed a commit
to savannahostrowski/cpython
that referenced
this pull request
Sep 22, 2024
…pilation (pythonGH-124131) Co-authored-by: Jason R. Coombs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the test helper compile directly from the “installed” sources.
This should avoid doing some unnecessary work, as well as possible issues in copying too much/too little metadata to a different filesystem. Hopefully, it'll fix the buildbot failure.