Fix typos in warnings, docstrings, comments and text files #123597

abstractee · 2024-09-02T10:07:37Z

This corrects some typos in comments, docstrings and text files.

cpython-cla-bot · 2024-09-02T10:07:39Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2024-09-02T10:07:42Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Wulian233 · 2024-09-02T10:32:43Z

Do not modify the idle help.html, as it is automatically generated and the typo was fixed 4 months ago.
e7ba6e9

"referencable" and "referenceable" are both acceptable spellings. Let's just leave this file as it is. https://en.wiktionary.org/wiki/referencable
#123201 (comment)

Wulian233 · 2024-09-02T10:33:22Z

Include/refcount.h

@@ -401,7 +401,7 @@ static inline Py_ALWAYS_INLINE void Py_DECREF(PyObject *op)
 * There are cases where it's safe to use the naive code, but they're brittle.
 * For example, if `op` points to a Python integer, you know that destroying
 * one of those can't cause problems -- but in part that relies on that
- * Python integers aren't currently weakly referencable.  Best practice is
+ * Python integers aren't currently weakly referenceable.  Best practice is


Suggested change

* Python integers aren't currently weakly referenceable. Best practice is

* Python integers aren't currently weakly referencable. Best practice is

Thanks for the feedback. Corrected.

~~Aren't both of these changes correct?~~

Wulian233 · 2024-09-02T10:34:07Z

Lib/idlelib/help.html

@@ -694,7 +694,7 @@ <h3>Shell window<a class="headerlink" href="#shell-window" title="Permalink to t
 <p>The editing features described in previous subsections work when entering
 code interactively.  IDLE’s Shell window also responds to the following:</p>
 <ul class="simple">
-<li><p><kbd class="kbd compound docutils literal notranslate"><kbd class="kbd docutils literal notranslate">C</kbd>-<kbd class="kbd docutils literal notranslate">c</kbd></kbd> attemps to interrupt statement execution (but may fail).</p></li>
+<li><p><kbd class="kbd compound docutils literal notranslate"><kbd class="kbd docutils literal notranslate">C</kbd>-<kbd class="kbd docutils literal notranslate">c</kbd></kbd> attempts to interrupt statement execution (but may fail).</p></li>


Suggested change

<li><p><kbd class="kbd compound docutils literal notranslate"><kbd class="kbd docutils literal notranslate">C</kbd>-<kbd class="kbd docutils literal notranslate">c</kbd></kbd> attempts to interrupt statement execution (but may fail).</p></li>

<li><p><kbd class="kbd compound docutils literal notranslate"><kbd class="kbd docutils literal notranslate">C</kbd>-<kbd class="kbd docutils literal notranslate">c</kbd></kbd> attemps to interrupt statement execution (but may fail).</p></li>

Removed the file from the commit. Thank you.

picnixz · 2024-09-02T10:49:35Z

Lib/_pyio.py

@@ -315,7 +315,7 @@ class IOBase(metaclass=abc.ABCMeta):

    This class provides dummy implementations for many methods that
    derived classes can override selectively; the default implementations
-    represent a file that cannot be read, written or seeked.
+    represent a file that cannot be read, written or sought.


While I understand this change, I think we can use seeked here. One existing wording is https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/seeked_event which relates to seek operations.

Ref python/cpython#123597

jaraco

LGTM (importlib/resources/_common.py).

vstinner · 2024-09-03T00:20:57Z

Merged, thanks. I don't think that it's worth it to backport the change.

terryjreedy · 2024-09-03T08:22:53Z

I want idlelib changes backported. Since _strptime change will not backport to 3.12, will do new PR after 3.13.0.

Ref python/cpython#123597

See python#123597. (cherry picked from commit 1f4a49e) Co-authored-by: abstractee

See python#123597. The typo in Icon/README.txt was fixed in the unmerged 3.13 backport python#123608 of the PR that added the text with the typo. (cherry picked from commit 1f4a49e) Co-authored-by: abstractee

See #123597. (cherry picked from commit 1f4a49e) Co-authored-by: abstractee

See #123597. The typo in Icon/README.txt was fixed in the unmerged 3.13 backport #123608 of the PR that added the text with the typo. (cherry picked from commit 1f4a49e) Co-authored-by: abstractee

See python/cpython#123597. (cherry picked from commit 1f4a49e) Co-authored-by: abstractee

abstractee requested review from terryjreedy, pganssle, abalkin, jaraco, warsaw, FFY00, brettcannon, ericsnowcurrently, ncoghlan, gpshead and tiran as code owners September 2, 2024 10:07

bedevere-app bot added the awaiting review label Sep 2, 2024

Wulian233 suggested changes Sep 2, 2024

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels Sep 2, 2024

picnixz added skip issue skip news labels Sep 2, 2024

picnixz reviewed Sep 2, 2024

View reviewed changes

Fix typos in comments

a32a7fd

abstractee force-pushed the fixed-typos branch from de29e75 to a32a7fd Compare September 2, 2024 11:17

jaraco added a commit to python/importlib_resources that referenced this pull request Sep 2, 2024

Fix typo in _temp_path comment.

d84ca37

Ref python/cpython#123597

jaraco approved these changes Sep 2, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels Sep 2, 2024

Merge branch 'python:main' into fixed-typos

200d6a0

hugovk changed the title ~~Fix typos in comments~~ Fix typos in warnings, docstrings, comments and text files Sep 2, 2024

vstinner merged commit 1f4a49e into python:main Sep 3, 2024
32 checks passed

bedevere-app bot removed the awaiting merge label Sep 3, 2024

abstractee deleted the fixed-typos branch September 3, 2024 09:12

jaraco added a commit to python/importlib_resources that referenced this pull request Sep 12, 2024

Fix typo in _temp_path comment.

a25f00e

Ref python/cpython#123597

terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Sep 23, 2024

[3.12] Backport idlelib typos

89cfda3

See python#123597. (cherry picked from commit 1f4a49e) Co-authored-by: abstractee

terryjreedy mentioned this pull request Sep 23, 2024

[3.12] Backport idlelib typos #124324

Merged

terryjreedy mentioned this pull request Sep 23, 2024

[3.13] Backport idlelib typos #124325

Merged

terryjreedy added a commit that referenced this pull request Sep 23, 2024

[3.12] Backport idlelib typos (#124324)

7d505fe

See #123597. (cherry picked from commit 1f4a49e) Co-authored-by: abstractee

zetaloop pushed a commit to zetaloop/IDLE-CN-base that referenced this pull request Nov 4, 2024

[3.12] Backport idlelib typos (#124324)

6e22283

See python/cpython#123597. (cherry picked from commit 1f4a49e) Co-authored-by: abstractee

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix typos in warnings, docstrings, comments and text files #123597

Fix typos in warnings, docstrings, comments and text files #123597

abstractee commented Sep 2, 2024

cpython-cla-bot bot commented Sep 2, 2024 •

edited

Loading

bedevere-app bot commented Sep 2, 2024

Wulian233 commented Sep 2, 2024

Wulian233 Sep 2, 2024

abstractee Sep 2, 2024

nineteendo Sep 2, 2024 •

edited

Loading

Wulian233 Sep 2, 2024

abstractee Sep 2, 2024 •

edited

Loading

picnixz Sep 2, 2024

jaraco left a comment

vstinner commented Sep 3, 2024

terryjreedy commented Sep 3, 2024 •

edited

Loading

	* Python integers aren't currently weakly referenceable. Best practice is
	* Python integers aren't currently weakly referencable. Best practice is

	<li><p><kbd class="kbd compound docutils literal notranslate"><kbd class="kbd docutils literal notranslate">C</kbd>-<kbd class="kbd docutils literal notranslate">c</kbd></kbd> attempts to interrupt statement execution (but may fail).</p></li>
	<li><p><kbd class="kbd compound docutils literal notranslate"><kbd class="kbd docutils literal notranslate">C</kbd>-<kbd class="kbd docutils literal notranslate">c</kbd></kbd> attemps to interrupt statement execution (but may fail).</p></li>

Fix typos in warnings, docstrings, comments and text files #123597

Fix typos in warnings, docstrings, comments and text files #123597

Conversation

abstractee commented Sep 2, 2024

cpython-cla-bot bot commented Sep 2, 2024 • edited Loading

bedevere-app bot commented Sep 2, 2024

Wulian233 commented Sep 2, 2024

Wulian233 Sep 2, 2024

Choose a reason for hiding this comment

abstractee Sep 2, 2024

Choose a reason for hiding this comment

nineteendo Sep 2, 2024 • edited Loading

Choose a reason for hiding this comment

Wulian233 Sep 2, 2024

Choose a reason for hiding this comment

abstractee Sep 2, 2024 • edited Loading

Choose a reason for hiding this comment

picnixz Sep 2, 2024

Choose a reason for hiding this comment

jaraco left a comment

Choose a reason for hiding this comment

vstinner commented Sep 3, 2024

terryjreedy commented Sep 3, 2024 • edited Loading

cpython-cla-bot bot commented Sep 2, 2024 •

edited

Loading

nineteendo Sep 2, 2024 •

edited

Loading

abstractee Sep 2, 2024 •

edited

Loading

terryjreedy commented Sep 3, 2024 •

edited

Loading