chore(ci): testing with Python3.10 and ZK 3.5.10, 3.6.3, 3.7.1 #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenSorriaux
force-pushed
the
feat/update-testing
branch
from
fc0c7b0 to
9578e0d
Compare
Codecov ReportBase: 94.43% // Head: 94.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
==========================================
+ Coverage 94.43% 94.51% +0.08%
==========================================
Files 56 57 +1
Lines 8367 8399 +32
==========================================
+ Hits 7901 7938 +37
+ Misses 466 461 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
StephenSorriaux
changed the title
houndci-bot
reviewed
Oct 1, 2022
StephenSorriaux
force-pushed
the
feat/update-testing
branch
from
39b3fbd to
538902e
Compare
Testing libs have been upgraded. The used java classpath now considers more .jar possible locations. test_connection.py tests is now done first, trying to make it less flaky. conftest.py has been added to give a way to display ZK cluster logs. Because of ZK 3.6 and 3.7 changes, configurations related to local session has been added. Disable GA fail-fast because of the flakiness
StephenSorriaux
force-pushed
the
feat/update-testing
branch
from
538902e to
80a121c
Compare
StephenSorriaux
requested review from
ceache and
jeffwidman
and removed request for
ceache and
jeffwidman
ceache
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
Make sure the lib is working with Python 3.10 and the latest ZK versions (3.5.10, 3.6.3, 3.7.1)
Proposed Changes
test_connection.pytotest__connection.pyto get it done first (poor way to try to get it less flaky, I confess) and deactivatefail-fastfeature in GA to get the tests' flakiness less painfulconftest.pyto give a way to get ZK logs when test fails (but needs the -s flag in pytest)setup.cfgDoes this PR introduce any breaking change?
No